This repository has been archived by the owner on Oct 18, 2018. It is now read-only.
Bug 767179 - Make user interface appear in fixed size dialogs on tablets. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be nice to format all the layout .xml files at the same time as landing this, since they're a mess of tabs and bad indentation. |
|
You'll want the Fennec patch from https://bugzilla.mozilla.org/show_bug.cgi?id=767179 as well. |
…ets. Specifically: * modify tablet specific styles in res/values-large-v11/sync_styles.xml. * derive SyncTheme from Theme (phone) or Theme.Dialog (tablet) as appropriate. * uniformize spacing to use SyncSpace dimension (20dp). * rather than using an external RelativeLayout and pinning the top and bottom bar to the parent top and bottom, use an external LinearLayout (style SyncContainer) with a middle ScrollView with weight 1 that absorbs all available space. This keeps the previous layout on phones but smoothly wraps content on tablets. * ensure that we resize all layouts when the keyboard is shown. * set the external LinearLayout (style SyncContainer) layout width, minWidth and maxWidth (to 600dip) on tablet only. We would like to set layout width and height to 600x600 dp or similar, but this doesn't work when the keyboard is shown. The current solution looks good but can have very tall dialog boxes. Nothing to be done, unfortunately.
|
Reviewed in #250. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit comment on second commit for detailed explanation of changes.