Skip to content
This repository has been archived by the owner on Oct 18, 2018. It is now read-only.

Conversation

mcomella
Copy link
Contributor

@mcomella mcomella commented Aug 6, 2013

by bumping version number.

Also took the liberty to update some licenses.

@rnewman
Copy link
Contributor

rnewman commented Aug 6, 2013

Good comment, but I also wanted a specific history for what changed between v1 and v2. That can either go in the case statement, or it can go in a comment above the version number, but it ought to go somewhere. Something like:

* -: No version number; implicit v1.
* 1: Added versioning. Bug 878670.
* 2: Bumping in Bug 901622 in order to regenerate add-on set after landing Bug 900964.

@rnewman
Copy link
Contributor

rnewman commented Aug 6, 2013

Also, did you see my test comment?

@mcomella
Copy link
Contributor Author

mcomella commented Aug 6, 2013

Also, did you see my test comment?

Yep, almost done.

@mcomella
Copy link
Contributor Author

mcomella commented Aug 6, 2013

@rnewman: All done addressing comments.

@rnewman
Copy link
Contributor

rnewman commented Aug 7, 2013

Looks good. Double-check that it works on a phone and land it land it! 👍

@mcomella mcomella merged commit 99ad32d into mozilla-services:develop Aug 7, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants