bug 1557706: fix systemtests to work with discarded reasons #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
commented
Jul 23, 2019
| @@ -325,6 +325,9 @@ def extract_payload(self, req): | |||
| has_kvpairs = True | |||
| raw_crash[fs_item.name] = fs_item.value | |||
|
|
|||
| if not raw_crash: | |||
| raise MalformedCrashReport("no_annotations") | |||
There was a problem hiding this comment.
This causes malformed crash reports which have no annotations to get dropped earlier. Otherwise, they go through the throttler and get dropped because it's an "unsupported product". Dropping it here with a "no annotations" reason reduces some of the work involved but also yields a better reason for someone testing crash reporting.
|
self-r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.