bug 1619644: handle None values in throttler #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
commented
Mar 24, 2020
| :return: string value | ||
|
|
||
| """ | ||
| return str(data.get(key, default)) |
There was a problem hiding this comment.
Having a single function that does this is easier than adjusting the code everywhere. This is a sanitizing function, so as we hit issues with new and exciting data problems, we can tweak this function accordingly.
willkg
commented
Mar 24, 2020
antenna/throttler.py
Outdated
| @@ -28,6 +28,20 @@ | |||
| RESULT_TO_TEXT = {0: "ACCEPT", 1: "DEFER", 2: "REJECT", 3: "FAKEACCEPT"} | |||
|
|
|||
|
|
|||
| def safe_get(data, key, default=""): | |||
| """Return data[key] or empty string. | |||
There was a problem hiding this comment.
Oops--this is wrong now. I need to update this.
It's now possible for the collector to get None values for crash annotations. None is not a string which makes some of the throttler rules sad. This adds a "safe_get" function which gets the value from the crash and forces it to be a string. Then we can use string functions on it.
|
self-r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now possible for the collector to get
Nonevalues for crash annotations.Noneis not a string which makes some of the throttler rules sad.This adds a
safe_getfunction which gets the value from the crash and forces it to be a string. Then we can use string functions on it.