bug-1819628: reject incoming crash reports by Android_PackageName #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
commented
Jan 17, 2024
| if is_not_supported: | ||
| logger.info("ProductName rejected: %r", product_name) | ||
| return True | ||
| return False |
There was a problem hiding this comment.
I cleaned up the logic here a little, but it should do the same thing it did before.
willkg
commented
Jan 17, 2024
willkg
force-pushed
the
willkg-bug-1819628-fenix
branch
from
fdfdc61
to
ccf89ec
Compare
This adds a map of product -> supported Android_PackageName values and a throttler rule to reject incoming crash reports where the configuration denotes a list of supported packagenames and either the Android_PackageName is missing or it's not in the supported list. The initial set of supported packagenames is provided in bug-1819628.
willkg
force-pushed
the
willkg-bug-1819628-fenix
branch
from
ccf89ec
to
46d6670
Compare
willkg
commented
Jan 17, 2024
| ) | ||
| else: | ||
| logger.info( | ||
| "Android_PackageName rejected: %s %r", product_name, packagename |
There was a problem hiding this comment.
Having this logged allows us to later look at the logs when someone asks us, "are we rejecting packagename xyz?" and then we can say "yes, and we got 1 billion of them yesterday!!!!"
smarnach
approved these changes
Jan 17, 2024
|
|
||
| # Supported packagenames values; these have to match the Android_PackageName of the | ||
| # incoming crash report | ||
| MOZILLA_PRODUCT_PACKAGENAMES = { |
There was a problem hiding this comment.
I'm wondering whether we'd prefer to have this data in a configuration file rather than in the source code, but I guess either way is fine.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a map of product -> supported
Android_PackageNamevalues and a throttler rule to reject incoming crash reports where the configuration denotes a list of supported packagenames and either theAndroid_PackageNameis missing or it's not in the supported list.The initial set of supported packagenames is provided in bug-1819628.