bug-1877856: run systemtest in CI #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
force-pushed
the
ci-systemtest
branch
15 times, most recently
from
4ac6ae5
to
4ab9017
Compare
relud
commented
Jan 31, 2024
| try: | ||
| yield conn.getresponse() | ||
| finally: | ||
| conn.close() |
There was a problem hiding this comment.
without this change I was getting test failures due to unclosed socket
relud
commented
Feb 1, 2024
| @@ -8,7 +8,7 @@ version: 2.1 | |||
| jobs: | |||
| main: | |||
| docker: | |||
| - image: cimg/base:2023.01 | |||
| - image: cimg/base:2024.01 | |||
There was a problem hiding this comment.
docker compose up --wait-timeout requires a newer version of docker compose
| @@ -18,7 +18,7 @@ jobs: | |||
| - checkout | |||
|
|
|||
| - setup_remote_docker: | |||
| version: 20.10.18 | |||
| version: docker24 | |||
There was a problem hiding this comment.
docker 20 is deprecated by circleci and will start experiencing scheduled brownouts in february https://discuss.circleci.com/t/remote-docker-image-deprecations-and-eol-for-2024/50176
willkg
approved these changes
Feb 1, 2024
i'll file a follow-up PR so that i can merge this and unblock #968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.