feat: add VAPID quality tracking metric messages #417
+88
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/SYNC-3842_metrics
… feat/SYNC-3842_metrics
… feat/SYNC-3842_metrics
… feat/SYNC-3842_metrics
… feat/SYNC-3842_metrics
pjenvey
requested changes
Jun 19, 2024
| // Capturing the vapid sub right now will cause too much cardinality. Instead, | ||
| // let's just capture if we have a valid VAPID, as well as what sort of bad sub | ||
| // values we get. | ||
| if let Some(header) = vapid.clone() { |
There was a problem hiding this comment.
Suggested change
| if let Some(header) = vapid.clone() { | |
| if let Some(ref header) = vapid { |
| @@ -298,7 +326,12 @@ fn validate_vapid_jwt( | |||
| return Err(VapidError::InvalidVapid(e.to_string()).into()); | |||
| } | |||
| _ => { | |||
| metrics.clone().incr("notification.auth.bad_vapid.other"); | |||
| let mut tags = Tags::default(); | |||
| tags.tags.insert("error".to_owned(), e.to_string()); | |||
There was a problem hiding this comment.
This isn't a suitable tag value, lots of their error variants produce strings with whitespace
Comment on lines
+108
to
+117
| tags.tags | ||
| .insert("error".to_owned(), e.as_metric().to_owned()); | ||
| metrics | ||
| .clone() | ||
| .incr_with_tags("notification.auth.error", Some(tags)); | ||
| }) | ||
| .unwrap_or_default(); | ||
| // For now, record that we had a good (?) VAPID sub, | ||
| metrics.clone().incr("notification.auth.ok"); | ||
| info!("VAPID sub: {:?}", sub) |
There was a problem hiding this comment.
A few things here:
- The lack of
subisn't really an actual error, maybe call this metric something else? Could it be a tag on the existingnotification.authmetric (moving all this intoparse_vapid)? - If it doesn't make sense as part of
parse_vapidI think ideally this extra work for metrics shouldn't occur untilvalidate_vapid_jwtsucceeds in validating - Is the new
notification.auth.oktotally necessary? We emitupdates.vapid.draft{version}for successfully validated vapid, we could get a similar number by subtracting the no sub metric from those 2 combined
|
|
||
| if let Some(sub_candiate) = data.get("sub") { | ||
| if let Some(sub) = sub_candiate.as_str() { | ||
| if !sub.starts_with("mailto:") { |
There was a problem hiding this comment.
Apparently https is also valid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: SYNC-3842