feat: introduce end_median for dual. #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`end_median` is an optional database config argument for `dual`. Like `median` it will filter UAIDs for migration by the last octet. (Note, this will still allow UAIDs that match against the `median`) This is an attempt to reduce hot tablet entries during migration phases. It is recommended that `end_median` be slowly ramped up instead of `median`. Closes SYNC-4198
pjenvey
requested changes
Mar 19, 2024
| @@ -96,6 +103,25 @@ impl DualClientImpl { | |||
| } else { | |||
| None | |||
| }; | |||
| // determine which uaids to move based on the last byte of their UAID. | |||
| // This should reduce the hot table problem. | |||
| let end_median = if let Some(end_median) = db_settings.end_median { | |||
There was a problem hiding this comment.
Let's also emit end_median in the startup metric as another tag alongside median
…es/autopush-rs into feat/SYNC-4198_end_median
pjenvey
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
end_medianis an optional database config argument fordual. Likemedianit will filter UAIDs for migration by the last octet. (Note,this will still allow UAIDs that match against the
median)This is an attempt to reduce hot tablet entries during migration phases.
It is recommended that
end_medianbe slowly ramped up instead ofmedian.Closes SYNC-4198