-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: autopush-common remove legacy autopush #708
refactor: autopush-common remove legacy autopush #708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a number of ApcErrorKind
variants that are no longer used (solely by legacy autopush) that could be removed.
I'm not sure if there's an easy way to detect these other than removing all of them then checking where rustc complains
Great catch @pjenvey , I removed those referenced in |
e8c069b
to
bbfccc8
Compare
@taddes I'm seeing even more unused variants! Sorry to persist on this but this is a good time to remove all the unnecessary ones (and if enough are removed we might even consider removing ApcError itself in the future). I've spotted |
c644832
to
456767d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seeing a couple here that could be removed such as the PongTimeout
and ExcessivePing
I mentioned
456767d
to
f5c01dc
Compare
@pjenvey I think that accounts for all of the unused variants. BroadcastError, GeneralError, ConfigError, & PayloadError
are all used externally directly, with the others covering errors using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm also seeing the Json
and Httparse
variants unused, can you double check those?
Hm, might those need to remain for the status method? |
Alright, got em @pjenvey ! |
🎉 |
Closes SYNC-4261
This will be somewhat more trivial in scope as SYNC-3451 will remove the dependencies and code related to some of these dependencies (usoto_core, rusoto_dynamodb, and serde_dynamodb)