bug: put markus metric handling on a deferred thread

Closes #1408
mozilla-services · Jul 1, 2020 · 6436453 · 6436453
1 parent 3033725
commit 6436453
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/autopush/metrics.py b/autopush/metrics.py
@@ -6,7 +6,7 @@
     Sequence
 )
 
-from twisted.internet import reactor
+from twisted.internet import (reactor, threads)
 
 import markus
 
@@ -92,16 +92,22 @@ def _make_tags(self, tags):
         return tags
 
     def increment(self, name, count=1, tags=None, **kwargs):
-        self._client.incr(self._prefix_name(name), count,
-                          tags=self._make_tags(tags))
+        threads.deferToThread(
+            self._client.incr(self._prefix_name(name), count,
+                              tags=self._make_tags(tags))
+        )
 
     def gauge(self, name, count, tags=None, **kwargs):
-        self._client.gauge(self._prefix_name(name), count,
-                           tags=self._make_tags(tags))
+        threads.deferToThread(
+            self._client.gauge(self._prefix_name(name), count,
+                               tags=self._make_tags(tags))
+        )
 
     def timing(self, name, duration, tags=None, **kwargs):
-        self._client.timing(self._prefix_name(name), value=duration,
-                            tags=self._make_tags(tags))
+        threads.deferToThread(
+            self._client.timing(self._prefix_name(name), value=duration,
+                                tags=self._make_tags(tags))
+        )
 
 
 def from_config(conf):