Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Push callback should not require the Encryption header for aes128gcm #1384

Closed
eoger opened this issue May 6, 2020 · 0 comments · Fixed by #1385
Closed

Push callback should not require the Encryption header for aes128gcm #1384

eoger opened this issue May 6, 2020 · 0 comments · Fixed by #1385
Assignees
@jrconlin
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.
Projects
Services Engineering

Comments

@eoger
Copy link

eoger commented May 6, 2020

Right now I get a 500 error using web-push 3.4.3, because it does not include this header for aes128gcm requests.
@jrconlin jrconlin self-assigned this May 6, 2020
jrconlin added a commit that referenced this issue May 6, 2020
@jrconlin
bug: do not require encryption header for APNs aes128gcm encoded …
9002bc6 
…messages

Includes better logging for uncaught APNs errors, since those were
getting dropped by cyclone.

Issue #1383
Closes #1384
@jrconlin jrconlin added the 1 Estimate - xs - This is a trivial change with clearly defined parameters. label May 6, 2020
@jrconlin jrconlin added this to Backlog: Misc in Services Engineering via automation May 6, 2020
@jrconlin jrconlin moved this from Backlog: Misc to In Review in Services Engineering May 6, 2020
@jrconlin jrconlin mentioned this issue May 6, 2020
Merged
Services Engineering automation moved this from In Review to Done May 7, 2020
pjenvey pushed a commit that referenced this issue May 7, 2020
@jrconlin
bug: do not require encryption header for APNs aes128gcm encoded …
148781c 
…messages (#1385)

* bug: do not require `encryption` header for APNs `aes128gcm` encoded messages

Includes better logging for uncaught APNs errors, since those were
getting dropped by cyclone.

Issue #1383
Closes #1384
@tublitzed tublitzed moved this from Done to Archived in Services Engineering May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.
Projects
Services Engineering
  
Archived
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: do not require encryption header for APNs aes128gcm encoded messages mozilla-services/autopush
2 participants
@jrconlin @eoger