Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_products_info: return products if product has no languages #67

Merged
merged 4 commits into from Feb 4, 2020
Merged

get_products_info: return products if product has no languages #67

merged 4 commits into from Feb 4, 2020

Conversation

oremj
Copy link
Contributor

@oremj oremj commented Feb 4, 2020

No description provided.

@oremj oremj requested a review from jbuck February 4, 2020 18:13
@oremj
Copy link
Contributor Author

oremj commented Feb 4, 2020

Going to merge to fix up prod, but if you could retro-review, that would be awesome.

@oremj oremj merged commit ef12e94 into master Feb 4, 2020
@oremj oremj deleted the fix-get-product-info branch February 4, 2020 18:14
jbuck
jbuck reviewed Feb 5, 2020
View reviewed changes
Copy link
Contributor

@jbuck jbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbuck jbuck jbuck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oremj @jbuck