New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bjoern support [do not merge yet] #65
Conversation
self.app = application | ||
self.sock = create_socket(host, port, address_family, | ||
socket_type, backlog=backlog) | ||
self.sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to say that this is not required by bjoern, but merely an option that I personally decided to turn on by default in the default bjoern initialization. If you don't set this option in all the other backends, then maybe you don't want to enable it for bjoern either.
Otherwise patch LGTM! |
@jonashaag Thanks for the review |
I'll cut a release tomorrow. Cool to have bjoern supported by Chaussette :) |
Just released 1.4.0 which includes the new API |
Thanks a lot @jonashaag |
No description provided.