-
Notifications
You must be signed in to change notification settings - Fork 16
Make error message explicit #545
Comments
Actually the way to install cliquet postgresql dependencies is to use:
rather than just installing SQLAlchemy. |
@Natim this is unrelated to the issue |
Would you prefer a link to docs in the error message? Or suggesting the command to run? Or Python libraries for PostgreSQL are missing ? |
I would explicitly indicate in the error which dependency is missing or has a problem. message = ("PostgreSQL sqlalchemy dependency missing. "
"Refer to installation section in documentation.") The reason is that sometimes you can have an installation error and knowing which lib is screwed can be useful. |
We wanted to avoid mentioning it explicitly, but if it can make sense, why not! As @Natim said there are several ones, but I think that if some of the other ones are missing, it fails somewhereelse within sqlalchemy. So why not mentionning sqla here indeed... |
yes, in this code, I see "if sqlachemy is None:" |
…tion-error Mention explicit dependency missing (fixes #545)
https://github.com/mozilla-services/cliquet/blob/master/cliquet/storage/postgresql/client.py#L61
"PostgreSQL dependencies missing" is not very clear.
Should be "SQLAlchemy missing" maybe ?
The text was updated successfully, but these errors were encountered: