This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
Manage authn/authz/groupfinder from settings (fixes #40) #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests fail because it requires last master of pyramid_multiauth with this mozilla-services/pyramid_multiauth#6 |
We should change "fxa_uid" to "fxa:uid" same for other policies. |
leplatrem
force-pushed
the
40-manage-authn-from-settings
branch
from
May 19, 2015 08:18
0a8d649
to
0998192
Compare
leplatrem
force-pushed
the
40-manage-authn-from-settings
branch
from
May 20, 2015 10:00
4f37084
to
e9cc7f5
Compare
@@ -76,6 +75,13 @@ | |||
'fxa-oauth.scope': 'profile', | |||
'fxa-oauth.state.ttl_seconds': 3600, # 1 hour | |||
'fxa-oauth.webapp.authorized_domains': '', | |||
'multiauth.policies': 'fxa', | |||
'multiauth.policy.fxa.use': ('cliquet.authentication.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the ".use".
-------------- | ||
|
||
Currently, if no authentication is set in settings, *Cliquet* relies on | ||
:term:`Firefox Accounts`, whose setup is tedious. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this should be "which" but apparently whose is the right word to use here.
almet
added a commit
that referenced
this pull request
May 27, 2015
…ttings Manage authn/authz/groupfinder from settings (fixes #40)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.