This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
Refactor the imports - Refs #34 #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some dependency to fix. Sorry for being late with this. |
| from cliquet import schema | ||
| from cliquet import utils | ||
|
|
||
|
|
||
| class BookmarkSchema(resource.ResourceSchema): | ||
| class BookmarkSchema(cliquet.ResourceSchema): |
There was a problem hiding this comment.
I suppose we could even rename cliquet.ResourceSchema to cliquet.Schema ?
|
Please don't say you're late :) Thanks a lot for your contribs!! |
|
Hey I have the same tests failing also on master. Is something with my local setup or am I forgetting something basic... ? |
| @@ -1,5 +1,5 @@ | |||
| import mock | |||
|
|
|||
| import cliquet | |||
|
refs nopressurelabs#1 |
|
Thanks for the comments. I'll keep working on this. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports resource directly in cliquet and change BaseResource to Resource. As per issue #34