Upgrade ujson to 1.35

[Natim]

Refs mozilla-services/readinglist#224

[Natim]

AFAIK it doesn't seems to fix the problem.

[Natim]

Or maybe it is because of missing , escape_forward_slashes=False ?

[Natim]

I added the option but I have no idea if it will actually works with normal json.

[Natim]

TypeError: __init__() got an unexpected keyword argument 'escape_forward_slashes'; uid=None; errno=None; agent=curl/7.35.0; authn_type=None

@leplatrem any idea of how to handle this?

[Natim]

The escape_forward_slashes only works with ultrajson.

[leplatrem]

The authors could not publish the version with the escape option on Pypi yet

[Natim]

The authors could not publish the version with the escape option on Pypi yet

The ujson people couldn't but a fork ultrajson was made available with it.

[leplatrem]

The escape_forward_slashes only works with ultrajson.

What if we do renderer = JSONRenderer(serializer=utils.json_serializer) ?

[leplatrem]

See ultrajson/ultrajson#185

[Natim]

@leplatrem well it doesn't really change the matter on this PR but ok I understand that.

[Natim]

With my last commit I've got two test failing on this kind of JSON:

u'{"responses":[{"status":201,"path":"/v0/mushrooms/e93e0961-0e09-4d8f-9ee0-8b05cdf18f41","body":{"data":{"last_modified":1446547536607,"name":"Trompette de la mort","id":"e93e0961-0e09-4d8f-9ee0-8b05cdf18f41"}},"headers":{"Last-Modified":"Tue, 03 Nov 2015 10:45:36 GMT","Content-Length":"114","ETag":""1446547536607"","Content-Type":"application/json; charset=UTF-8","Access-Control-Expose-Headers":"Retry-After, Content-Length, Alert, Backoff"}}]}'

[leplatrem]

nit: I'm not 100% sure that it is better, but you can do json_serializer = json.dumps

[leplatrem]

nit: I'm not 100% sure that it is better, but you could do json_serializer = functools.partial(json.dumps, escape_forward_slashes=False)

[Natim]

Telepathy for the win 👍

[Natim]

Well it is even worse actually :(

[leplatrem]

I tried to update this, but found a problem in the JSON serialization of batch responses:

It means that " are not escaped within strings :/

[Natim]

It means that " are not escaped within strings :/

Yes it is what I also noticed, do you know if it is a bug with your ultrajson fix?

[leplatrem]

I guess it is a known bug, with a pending PR to fix it.

>>> import ujson
>>> ujson.dumps('"')
'"\\""'

>>> import json
>>> json.dumps('"')
'"\\""'

>>> ujson.dumps('"', escape_forward_slashes=False)
'"""'

[leplatrem]

I updated this. Needs rebase.

[Natim]

Let me rebase then 👍

[leplatrem]

@Natim final r+ ?

[Natim]

GG mat r+