This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
Refactor Redis client instantiation (fixes #567) #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
changed the title
leplatrem
force-pushed
the
refactor-redis-client-instantiation
branch
2 times, most recently
from
f3ec3c5
to
ca53bcf
Compare
|
|
||
| @property | ||
| def settings(self): | ||
| return self._client.connection_pool.connection_kwargs |
There was a problem hiding this comment.
let's return a copy with a dict() wrapping, so people can't change the settings
leplatrem
force-pushed
the
refactor-redis-client-instantiation
branch
3 times, most recently
from
06e5662
to
70fe1d5
Compare
|
r+ |
leplatrem
force-pushed
the
refactor-redis-client-instantiation
branch
from
70fe1d5
to
5581e0b
Compare
leplatrem
added a commit
that referenced
this pull request
Nov 12, 2015
…nstantiation Refactor Redis client instantiation (fixes #567)
glasserc
added a commit
that referenced
this pull request
May 20, 2016
Make this a separate link. If Kinto ever gets a real homepage, we can link the word ``Kinto`` to that. This commit, and the previous one, fixes #568.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tarekziade r?