[CONSVC-1729] feat: introduce approval for partners #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiftran
force-pushed
the
2-ppl-partner-sign-off
branch
2 times, most recently
from
c3c3fa1
to
b1b25a1
Compare
tiftran
force-pushed
the
2-ppl-partner-sign-off
branch
from
b1b25a1
to
dddc7aa
Compare
tiftran
changed the title
ncloudioj
reviewed
Apr 28, 2022
consvc_shepherd/models.py
Outdated
|
|
||
| def clean(self): | ||
| if ( | ||
| self.settings_type.is_active is False |
There was a problem hiding this comment.
Nit:
Suggested change
| self.settings_type.is_active is False | |
| !self.settings_type.is_active |
There was a problem hiding this comment.
! self.settings_type.is_active isn't valid python will be changing it to not self.settings_type.is_active
There was a problem hiding this comment.
Doh, my Python is getting Rusty 😂.
ncloudioj
reviewed
Apr 28, 2022
contile/admin.py
Outdated
| messages.info(request, f"Partner: {partner.name} has been approved") | ||
| else: | ||
| messages.error( | ||
| request, "Approver is the same user that updated the partner" |
There was a problem hiding this comment.
Nit: let's also point out how this should be done, such as "This change can't be approved by the same editor, please get another reviewer for approval".
tiftran
added a commit
that referenced
this pull request
Aug 3, 2022
* feat: introduce approval for partners * feedback changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decided that if a partner setting has changed, you are unable to create a snapshot with that partner unless it has been approved.
closes #23