Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker-compose file #4

Merged
merged 3 commits into from
Mar 12, 2022
Merged

add docker-compose file #4

merged 3 commits into from
Mar 12, 2022

Conversation

tiftran
Copy link
Contributor

@tiftran tiftran commented Mar 10, 2022

added a docker-compose file, for people (and myself) who want to work with a docker work-flow

@tiftran tiftran requested a review from a team March 10, 2022 08:27
app:
tty: true
env_file:
- .env
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file missing?

Copy link
Contributor Author

@tiftran tiftran Mar 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes i should probably have a .env.example

@tiftran tiftran requested a review from jrconlin March 11, 2022 05:23
Copy link
Member

@pjenvey pjenvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an addition to the README about setting up an .env too?

@tiftran tiftran merged commit 7996f98 into main Mar 12, 2022
@tiftran tiftran deleted the docker-compose branch March 13, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants