[DISCO-2325] Create JSON Schema Validation for Control Mechanism #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taddes
changed the title
tiftran
approved these changes
Apr 21, 2023
.env.example
Outdated
Comment on lines
4
to
10
| DB_USER=postgres | ||
| DB_HOST=localhost | ||
| DB_PASS=postgres | ||
| DJANGO_SETTINGS_MODULE=consvc_shepherd.settings | ||
| OPENIDC_HEADER_PREFIX="accounts.google.com:" | ||
| OPENIDC_HEADER="x-goog" |
There was a problem hiding this comment.
lets move this out since it's included in your last PR
There was a problem hiding this comment.
Sounds good! I may just match to what's on main now and there shouldn't be any conflicts when merging.
Comment on lines
+131
to
+136
| # DS_Store files for macOS | ||
| **/.DS_Store | ||
|
|
||
| # VS Code configuration files | ||
| .vscode/* | ||
| !.vscode/launch.json |
consvc_shepherd/admin.py
Outdated
| @@ -22,7 +22,7 @@ def publish_snapshot(modeladmin, request, queryset): | |||
| snapshot.launched_by = request.user | |||
| snapshot.launched_date = timezone.now() | |||
| content = json.dumps(snapshot.json_settings, indent=2) | |||
| with open("./schema/shepherd.schema.json", "r") as f: | |||
| with open("./schema/filter.schema.json", "r") as f: | |||
There was a problem hiding this comment.
actually can we rename it as adm_filter instead? sorry 😅
schema/test_schema.py
Outdated
| @@ -10,7 +10,7 @@ class JSONSchema(TestCase): | |||
|
|
|||
| def test_schema(self): | |||
|
|
|||
| with open("./schema/shepherd.schema.json", "r") as f: | |||
| with open("./schema/filter.schema.json", "r") as f: | |||
There was a problem hiding this comment.
same here please and thank you
| @@ -0,0 +1,56 @@ | |||
| { | |||
There was a problem hiding this comment.
Looks good! We'll add tests when Shepherd is able to produce json!
taddes
deleted the
DISCO-2235-json-schema-validation-for-contol-mechanism
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-2325
GitHub: #95
Description
The goal of this task is to create the new JSON Schema for the Allocations of Kevel and adM partner advertisements. The document allows the distribution of ads by percentage supplying a percentage from 0 - 100 between the two and their occurrence in the array/list defines the Contile tiles from left to right, or the 0th index up.
The schema has description values for each key which supply sufficient context for anyone viewing the ticket.
Note: this task is only to create the valid schema. Subsequent tickets will cover the validation process, tests and potentially defining a model for this data.
A lengthy regex has been supplied to validate the title label in the format:
SOV-<UTC datetime:YYYYMMDDHHMMSS>. For readability, here are the capture groups and their restrictions as it's not super readable in the JSON. We want an accurate representation of actual correct datetimes, hence the need to define multiple capture groups that ensure Y, M, D, h, m, s values are correctSee JSON Schema docs on regex matching here