Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove references to BrowserID #100

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

jrconlin
Copy link
Member

@jrconlin jrconlin commented Jun 6, 2024

Description

Remove references to active use of BrowserID except for legacy information.

Issue(s)

Closes: SYNC-4209

@@ -58,7 +58,7 @@ Glossary
This is the only secret shared with the client and is different for each
auth token.

Generation Number
Generation Number (obsolete)
Copy link
Member

@pjenvey pjenvey Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs in this repo seem to largely predate FxA's use of oauth so even though this references browserid here I'm not entirely sure generation has been completely obsoleted. We still have code in the oauth path that checks for generation as a fallback to keys_changed_at.

The FxA /v1/verify endpoint tokenserver uses claims to potentially return generation in its response but it's not a required field, so we have an Option<i64> for it.

So we should maybe punt on marking this as obsolete for now? I'm also a bit confused because such things like keys_changed_at are basically contents of an opaque token with the oauth impl., but apparently a generation value that our oauth verifier might be utilizing is not from the token itself.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, totally fair. It wasn't super clear to me either, so I had doubts. I'll remove the (obsolete) tag.

@jrconlin jrconlin merged commit 915a503 into master Jul 3, 2024
@pjenvey pjenvey deleted the docs/SYNC-4209_browserip branch July 3, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants