add amo pipeline updates #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajvb
previously approved these changes
Jul 18, 2019
| if (!email.equals(nb)) { | ||
| buf += ", " + nb; | ||
| } | ||
| alert.addMetadata("email", buf); |
There was a problem hiding this comment.
not blocking, but packing multiple email addresses into one metadata kv pair seems like it may lead to pain later (and pain now with regards to analyzing and searching through alerts in bq, via queries or in something like redash)
There was a problem hiding this comment.
yeah, completely agree. I'm not sure what the best way to handle this is right now, we wouldn't want something like multiple keys either I suspect.
It's probably worth standardizing on some sort of metadata value array type that applies constraints on how this is constructed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.