Whitelisted IPs support #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameihm0912
suggested changes
Feb 22, 2019
src/main/java/com/mozilla/secops/state/DatastoreStateInterface.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mozilla/secops/whitelistedips/WhitelistedIpsLabeler.java
Outdated
Show resolved
Hide resolved
Remove whitelistedips package and put whitelist checking code in IprepdIO. Revert optional namespace code.
ameihm0912
approved these changes
Feb 26, 2019
There was a problem hiding this comment.
Looks good 👌
Some tests would be good here, we have some examples of using the datastore emulator in https://github.com/mozilla-services/foxsec-pipeline/blob/master/src/test/java/com/mozilla/secops/state/StateTest.java but can add those later
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked By: mozilla-services/foxsec-pipeline-contrib#3Requires a fix in the slackbot db code first, as the pipeline's
Stateobject expects the object to be stored as json within thestatefield.Integrates with the ip whitelist slackbot by marking alerts as "iprepd exempt". Alerts are stored with metadata but not sent to iprepd.