This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Features/issue 769 #770
Closed
Features/issue 769 #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -647,7 +665,21 @@ func (h *HttpBulkIndexer) Index(body []byte) (success bool, err error) { | |||
| return false, err | |||
| } else { | |||
| request.Header.Add("Accept", "application/json") | |||
| response, err := h.client.Do(request) | |||
| response, err := h.clientConn.Do(request) | |||
There was a problem hiding this comment.
It seems to me that the SetDeadline() calls should be happening immediately before this clientConn.Do() call. The first time through it's not so bad, but for subsequent requests the deadline is set before returning from this function. Theoretically we could end up burning through our timeout interval before the next call to Index() even happens.
|
Also, the commit history on this PR is a bit whack. I'd be very grateful if you could fix it up so there aren't any extraneous commits attached to it, ideally just a single commit that reflects the diff btn dev and your branch. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding http_timeout for http post in elasticsearch output for issue #769