[Landed] Added LocalStorage adapter. #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this._db = null; | ||
| // public properties | ||
| this.dbname = dbname; | ||
| this._keyStoreName = `${this.dbname}/__keys`; |
There was a problem hiding this comment.
Is this key a public one? (it's prefixed by _)
|
I really like to have different adapters, thanks for doing this. The code looks good to me. r+ (with comments) |
n1k0
force-pushed
the
localStorage-adapter
branch
from
4da6891
to
f0cdd5b
Compare
n1k0
force-pushed
the
localStorage-adapter
branch
from
f0cdd5b
to
2122c84
Compare
n1k0
added a commit
that referenced
this pull request
Jul 27, 2015
[WiP] Added LocalStorage adapter.
n1k0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ugly as hell but works as a proof of concept. Will pursue next week.