Skip to content
This repository has been archived by the owner on May 24, 2019. It is now read-only.

Do not sent POST body to Sentry #261

Closed
jaredlockhart opened this issue Apr 13, 2016 · 5 comments
Closed

Do not sent POST body to Sentry #261

jaredlockhart opened this issue Apr 13, 2016 · 5 comments

Comments

@jaredlockhart
Copy link
Collaborator

We presently use Sentry to log exceptions, however this will send the POST body in its entirety to our ops controlled sentry instance which will contain unobfuscated URLs which come from users histories. We should be omitting or obfuscating this in some way to prevent leaking users histories.

@jaredlockhart
Copy link
Collaborator Author

@relud @jvehent @mostlygeek Feedback?

@relud
Copy link
Member

relud commented Apr 13, 2016

I definitely think it should be omitted

@mostlygeek
Copy link

I favor omission too. Are there circumstances where having the URLs would help with debugging? If not, then they definitely should be omitted.

@jvehent
Copy link

jvehent commented Apr 13, 2016

Aye, let's omit and reduce the number of places where we store user sensitive stuff.

@jaredlockhart
Copy link
Collaborator Author

Okay I was not paying attention. This is the wrong repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants