This repository has been archived by the owner on May 24, 2019. It is now read-only.
enable CSP #306
Merged
enable CSP #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With #307 the only reports we've gotten since the 1.14 deploy are from a lastpass extension and Chrome < 46 on Android, because it doesn't support hash script-srcs. So I think this OK to turn on, but we can wait for more data too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the CSP policy added in #303
If we don't have any CSP errors, since that was deployed this should be good to go.
I don't have the local environment setup, but django-csp defaults to
CSP_REPORT_ONLY = False, so the header should be set properly.