This repository has been archived by the owner on Mar 19, 2019. It is now read-only.
Add support for eslint and update the code with the new rules #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
||
| env: | ||
| "amd": true | ||
| "browser": true |
There was a problem hiding this comment.
Should this be "browser": false (or just omitted)? Does the server serve any client side code?
There was a problem hiding this comment.
Correct, we don't serve any client-side code.
Natim
force-pushed
the
eslint-take2
branch
3 times, most recently
from
7d8269f
to
f558e37
Compare
Natim
changed the title
Natim
added a commit
that referenced
this pull request
Aug 22, 2014
Add support for eslint and update the code with the new rules
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.