Skip to content

Commit

Permalink
Deprecate geoip and snappy as they are no longer used
Browse files Browse the repository at this point in the history
There is no sandbox specific functionality in these modules so the
standard Lua 5.1 packages could also be used.
  • Loading branch information
trink committed Mar 6, 2018
1 parent 94cbafd commit 0898fcd
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ cjson
compat
cuckoo_filter
elasticsearch
geoip
# geoip # deprecated use maxminddb
heka
hyperloglog
jose
Expand All @@ -90,7 +90,7 @@ parquet
postgres
rjson
sax
snappy
# snappy # deprecated
socket
ssl
struct
Expand Down
2 changes: 1 addition & 1 deletion build/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ build_lua_sandbox_extensions() {
local ext
packages="git c++-compiler"
cmake_args=""
# todo add support for aws geoip jose kafka parquet snappy systemd moz_pioneer moz_security
# todo add support for aws jose kafka parquet systemd moz_pioneer moz_security
for ext in bloom_filter circular_buffer cjson compat cuckoo_filter \
elasticsearch heka hyperloglog lfs lpeg lsb maxminddb moz_ingest \
moz_telemetry openssl postgres rjson sax \
Expand Down
4 changes: 3 additions & 1 deletion geoip/index.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Lua GeoIP Module
# Lua GeoIP Module (DEPRECATED)

https://github.com/agladysh/lua-geoip

See: https://mozilla-services.github.io/lua_sandbox_extensions/maxminddb/
2 changes: 1 addition & 1 deletion snappy/index.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Lua Snappy Module
# Lua Snappy Module (DEPRECATED)

This comment has been minimized.

Copy link
@bbinet

bbinet Apr 23, 2018

Contributor

What would you recommend as a replacement for snappy to efficiently compress data in an output plugin before sending to a remote tcp endpoint?


https://github.com/forhappy/lua-snappy

2 comments on commit 0898fcd

@trink
Copy link
Contributor Author

@trink trink commented on 0898fcd Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zstd based on our initial tests it produced output 2x smaller and 2x faster than snappy
#304

@bbinet
Copy link
Contributor

@bbinet bbinet commented on 0898fcd Apr 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Please sign in to comment.