Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third Party Sandbox Extensions repo layout #73

Closed
champtar opened this issue Feb 6, 2017 · 2 comments
Closed

Third Party Sandbox Extensions repo layout #73

champtar opened this issue Feb 6, 2017 · 2 comments

Comments

@champtar
Copy link
Contributor

champtar commented Feb 6, 2017

Hi @trink,

I know you added this wiki page a while ago:
https://github.com/mozilla-services/lua_sandbox_extensions/wiki/Third-Party-Sandbox-Extensions

I'm just wondering what do you prefer:

  1. copy top level CMakeLists.txt into the third party repo (not ideal)
  2. improve this CMakeLists.txt to be able to reference just the external extension at configure time, maybe something like -DEXTERNAL_EXT_<ext-name>=<ext-path>

I'm now using the original project, not a fork of a fork champtar@68fdb46
original PR: #50

Regards

@trink
Copy link
Contributor

trink commented Feb 6, 2017

The top level CMakeLists.txt is not what you want for a standalone luasandbox-ext repo. It would be closer to a modified copy of the sandbox_modules.cmake and would be unique to the new repo with no dependencies on the lua_sandbox_extension repo.

@trink
Copy link
Contributor

trink commented Jul 11, 2017

The repo layout will vary, here is an example of a C module (creating three packages, a C library and lua51/luasandbox bindings) https://github.com/trink/streaming_algorithms

@trink trink closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants