Add MaxMindDB extension (geoip2) #50
Conversation
Signed-off-by: Etienne Champetier <etienne.champetier@anevia.com>
| @@ -0,0 +1,3 @@ | |||
| # Lua MaxMindDB Module | |||
|
|
|||
| https://github.com/champtar/lua-maxminddb (fork) | |||
There was a problem hiding this comment.
I would prefer if that cast could be upstreamed to the original repo https://github.com/fabled/lua-maxminddb instead of using a fork of a fork.
| set(CPACK_PACKAGE_VERSION_MINOR ${PROJECT_VERSION_MINOR}) | ||
| set(CPACK_PACKAGE_VERSION_PATCH ${PROJECT_VERSION_PATCH}) | ||
| set(CPACK_PACKAGE_VENDOR "Mozilla Services") | ||
| set(CPACK_PACKAGE_CONTACT "Mike Trinkala <trink@mozilla.com>") |
There was a problem hiding this comment.
In general we don't accept extensions that we don't use at Mozilla. Since this and hundreds of other Lua modules can be built for use in the sandbox we cannot take on the maintenance and support of all of them. Each third party extension can easily be a standalone project of its own producing a luasandbox-module.package. Proposal: we create a third party module list in the Wiki that can be maintained independently.
There was a problem hiding this comment.
Hi @trink
Sorry for the late reply.
Do you see an easy way to have such standalone project and not duplicate CMakeLists.txt?
Maybe a -DEXTERNAL_EXT_<ext-name>=<ext-path>?
Hi,
Small PR to add MaxMindDB (geoip2) extension