Document JSON output (#31) #32
Conversation
|
@Gankra I figure while it's nice to have the schema in the rust-minidump repository issues, it'd be best if we "officially" documented it in this repo. I went through a bunch of crash reports and the stackwalker.cc code and some other things and fleshed out the schema you threw together. My gut feeling is that it's probably missing things, still, but we can hone it in this PR and then land it and iterate on that. What do you think? |
README.rst
Outdated
| "threads_index": <int>, // index in threads for the crashing thread | ||
| "total_frames": <int>, // total frames listed here -- max 10 | ||
| "frames": [ | ||
| // for i in range(min(10, frame_count)) |
There was a problem hiding this comment.
I thought we removed this truncation because it was confusing?
There was a problem hiding this comment.
I forgot about that! Good catch!
|
I fixed the thing @Gankra noticed and also added a bunch of other stuff I saw while reading through stackwalker.cc including the new |
README.rst
Outdated
| "symbols_fetch_time": <float>, // optional, time in ms it took to fetch symbol file from url; omitted | ||
| // if the symbol file was in disk cache | ||
| "symbol_url": <string>, // optional, url of symbol file | ||
| "cert_subject": ? // optional |
There was a problem hiding this comment.
I couldn't figure out what this was and I haven't seen examples in crash reports processed by Socorro.
@gabrielesvelto , @Gankra : Any ideas what this is?
There was a problem hiding this comment.
The cert_subject field contains the entity that signed a given module using Microsoft's Authenticode system. For our modules for example this is going to be "Mozilla Corporation", Microsoft own modules will be signed by "Microsoft Windows" or "Microsoft Corporation" and so on. The minidump-analyzer retrieves this information when it processes a crash and stuffs it in an annotation called ModuleSignatureInfo.
Socorro's stackwalker uses this info to populate that field.
|
Note gabriel found several errors here (I copy-pasted your schema): rust-minidump/rust-minidump#170 (comment) |
|
FYI I compared the output directly with what we get in Socorro. So mine was one of those "the implementation is the spec" kind of things. |
|
I double-checked and those are all errors. I'll fix and then land this. Thank you both! |
Couple of thoughts: