Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1524291 Add certSubject to modules ping schemas #255

Merged
merged 1 commit into from Feb 8, 2019
Merged

Bug 1524291 Add certSubject to modules ping schemas #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions schemas/telemetry/modules/modules.4.parquetmr.txt
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@ message modules {
optional binary debugName (UTF8);
optional binary version (UTF8);
optional binary debugID (UTF8);
optional binary certSubject (UTF8);
}
}
}
Expand Down
6 changes: 6 additions & 0 deletions schemas/telemetry/modules/modules.4.schema.json
View file
Open in desktop
Expand Up @@ -935,6 +935,12 @@
"modules": {
"items": {
"properties": {
"certSubject": {
"type": [
"string",
"null"
]
},
"debugID": {
"type": [
"string",
Expand Down
1 change: 1 addition & 0 deletions templates/telemetry/modules/modules.4.parquetmr.txt
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@ message modules {
optional binary debugName (UTF8);
optional binary version (UTF8);
optional binary debugID (UTF8);
optional binary certSubject (UTF8);
}
}
}
Expand Down
3 changes: 3 additions & 0 deletions templates/telemetry/modules/modules.4.schema.json
View file
Open in desktop
Expand Up @@ -32,6 +32,9 @@
},
"debugID": {
"type": [ "string", "null" ]
},
"certSubject": {
"type": [ "string", "null" ]
}
}
}
Expand Down
6 changes: 4 additions & 2 deletions validation/telemetry/modules.4.windows.pass.json
View file
Open in desktop
Expand Up @@ -21,13 +21,15 @@
"name": "firefox.exe",
"debugName": "firefox.pdb",
"debugID": "3046805AB5E34628BC9B5041DF253A02C",
"version": "53.0.0.6228"
"version": "53.0.0.6228",
"certSubject": "Mozilla Corporation"
},
{
"name": "ntdll.dll",
"debugName": "wntdll.pdb",
"debugID": "9D5EBB427B3449C0BA160009A90706251",
"version": "10.0.14393.479"
"version": "10.0.14393.479",
"certSubject": "Microsoft Windows"
},
{
"name": "KERNEL32.DLL",
Expand Down