New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master branch #279
Merged
Update master branch #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue 138 - Fix the properties in the telemetry environment template
This fixes schema validation issues where we were receiving some leftover log entries from the v1 study with v2 pings
Revert "Make branch required"
This information is redundant, but we're adding the field for now to support https://bugzilla.mozilla.org/show_bug.cgi?id=1452745. This just adds a little bit of extra validation on the server side to make sure that the field is properly specified if it is present (obviously older versions will not have the field).
Add `metadata.StartupCrash` field, specify required fields.
* Add mobile metrics ping * Add JSON Schema for mobile metrics ping * Add createdDate and createdTimestamp for mobile events pings * Add experiments for mobile events pings * Request changes
Add ipc_channel_error to crash ping schema
Bug 1455385 - Move mobile-event 'os' to partitions
Bug 1455383 - Change core ping partitions
* Bug 1453376 - Add mercurial hgpush event ping - Add a new eng-workflow namespace - Add a ping for mercurial repository push events * Fix review feedback - Change reviewSystemUsed enum to a plain string with documentation - Document pushDate integer timestamp and set a minimum value - Punctuation, misc. docstring fixups
Fix hgpush schema path
Bug 1454739 - Add geo_subdivision to telemetry_new_profile_parquet
Bug 1462381 - Update heartbeat ping validation
Update compiled new-profile parquet schema
* Add the downgrade ping for bug 1463198.
* Add instructions for adding a new schema.
bug 1460595 - Add an event ping
* Make submission_timestamp datetime formatted * Remove non-failing datetime test In RapidJSON, formats are optionally enforced. The expected failing test was then not failing. We're not as concerned with validating these fields, so we're removing the test.
As described in the [Fennece Mobile Activation Ping design doc](https://docs.google.com/document/d/1D-0m3TRvIAOzGtkBNjaddyVr7baE7uEhiBUFyVQr2pg)
This makes mobile/activation consistent with existing pings (core and mobile events) that have an integer "tz" field given in minutes.
Add default schemas for most known docTypes
* Add stub ping specific fields and limit `installer_type` to valid values
* 1556684: Fix label length so it can support any metric name * Add glean CHANGELOG
* Add a reference prio ping generated by Firefox 69 nightly * Update prio payload version to a string enum * Add generated schema for Prio
Fenix sends two new Glean pings (`history_sync` and `bookmarks_sync`), but `_` wasn't allowed in schema names.
Add schemas for Glean history and bookmarks sync pings
Fix incompatible types in glean schemas cc @whd for deploy
fbertsch
approved these changes
Jun 19, 2019
whd
pushed a commit
that referenced
this pull request
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we can do #278 we'll need to update master.