Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_admin_without_uac to the launcher-process-failure ping #399

Merged
merged 1 commit into from Sep 3, 2019
Merged

Add is_admin_without_uac to the launcher-process-failure ping #399

merged 1 commit into from Sep 3, 2019

Conversation

msmania
Copy link
Contributor

@msmania msmania commented Sep 3, 2019 •
edited

This patch is to add a new field is_admin_without_uac in the existing launcher-process-failure ping.

https://bugzilla.mozilla.org/show_bug.cgi?id=1567605

Checklist for reviewer:

  • Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs
  • Trigger the integration CI test by pushing this revision as discussed in the README

For glean changes:

  • Update include/glean/CHANGELOG.md

acmiyaguchi
acmiyaguchi approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@acmiyaguchi acmiyaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@acmiyaguchi acmiyaguchi merged commit 93d01f6 into mozilla-services:dev Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acmiyaguchi acmiyaguchi acmiyaguchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msmania @acmiyaguchi