Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'silent' to installer ping #453

Merged
merged 1 commit into from Nov 27, 2019
Merged

Add 'silent' to installer ping #453

merged 1 commit into from Nov 27, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 22, 2019

Fixes #452

Checklist for reviewer:

  • Scan the PR and verify that no changes (particularly to .circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logs
  • Trigger the integration CI test by pushing this revision as discussed in the README

For glean changes:

  • Update include/glean/CHANGELOG.md

Copy link
Contributor

@acmiyaguchi acmiyaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@@ -52,4 +52,5 @@ message install {
optional binary attribution (UTF8);
optional binary profile_cleanup_prompt (UTF8);
optional boolean profile_cleanup_requested;
optional boolean silent;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parquet schemas have fallen out of favor, only updates to the JSON Schemas will show up in changes to the BigQuery tables.

@acmiyaguchi acmiyaguchi merged commit 68fa79c into mozilla-services:master Nov 27, 2019
@ghost
Copy link
Author

ghost commented Nov 27, 2019

Thanks! Are you who I should be specifically tagging for review on these kinds of things?

The parquet schemas have fallen out of favor, only updates to the JSON Schemas will show up in changes to the BigQuery tables.

Can the readme be updated to reflect that? As someone who only interacts with this stuff occasionally, it's difficult to keep up with all the changes that are always happening, and a little bit of updated documentation would go a long way.

@acmiyaguchi
Copy link
Contributor

In general, you should be able to request review and get a deploy from someone on the Data Platform team. I'm familiar with the repository, for feel free to tag me if there isn't someone else who has more context.

Can the readme be updated to reflect that?

Yes, it can. The ingestion pipeline has changed a bit during our GCP migration, leading to a drift in the documentation. The new process of modifying the schema is simpler though, once documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'silent' to installer ping
1 participant