This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
r?fzzzy r?kitcambridge Use express #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not rendering correctly
| const express = require("express"); | ||
| const bodyParser = require('body-parser'); | ||
| const morgan = require("morgan"); | ||
| const linker = require("./linker"); |
There was a problem hiding this comment.
Why repeat const over and over instead of using the comma form?
There was a problem hiding this comment.
I don't like the comma form, it's harder to edit and rearrange, each line doesn't stand on its own.
There was a problem hiding this comment.
I disagree. The fact that each line doesn't stand on it's own is the advantage.
Fix hooking up react on the client side in the express-wip branch
ianb
added a commit
that referenced
this pull request
May 28, 2015
r?fzzzy r?kitcambridge Use express
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #410, gets rid of models.js and so fixes #361, and touches a bunch of the server here and there.