-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide standardized way to run checks and format results #84
Conversation
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 97.80% 98.34% +0.54%
==========================================
Files 18 18
Lines 591 605 +14
Branches 85 84 -1
==========================================
+ Hits 578 595 +17
+ Misses 9 7 -2
+ Partials 4 3 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks like this PR needs some test tweaks to account for the changes. Going to start those now, but I wouldn't hate an early review. I'm planning on landing this, and maybe a follow-on PR to centralize check registration as well before turning my attention back to the FastAPI integration, since I think these PRs will affect that implementation. |
- use client instead of request factory - automatically clear registry, and don't handle Django version <2 - test response content when debug is enabled and disabled
Closing this and recreating with the PR I was going to submit as a follow-on, but makes sense to add on top of this |
This PR provides functions and dataclasses in the
dockerflow.checks
package to run registered checks (both synchronously and asynchronously) and return the results of the checks in a standardized manner.