Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema is not an html attribute #946

Merged
merged 1 commit into from Mar 25, 2019
Merged

Conversation

graingert
Copy link
Contributor

Reasons for making this change

schema is not an html attribute

Checklist

  • I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
    • If I'm adding a new section, I've updated the Table of Content
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@epicfaace
Copy link
Member

Thanks for the catch @graingert ! Can you make your change in the new docs folder, https://github.com/mozilla-services/react-jsonschema-form/blob/master/docs/form-customization.md, instead of README.md?

@epicfaace
Copy link
Member

@graingert just bumping this!

@graingert
Copy link
Contributor Author

graingert commented Mar 16, 2019

@epicfaace can you take over this?

@epicfaace epicfaace added this to In progress in Pending bugfixes/features/enhancements via automation Mar 16, 2019
@epicfaace epicfaace self-assigned this Mar 17, 2019
@epicfaace epicfaace merged commit 9104a71 into rjsf-team:master Mar 25, 2019
Pending bugfixes/features/enhancements automation moved this from In progress to Done Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants