Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Set the NODE_ENV environment variable in prod #4326

Closed
chenba opened this issue Apr 10, 2018 · 0 comments
Closed

Set the NODE_ENV environment variable in prod #4326

chenba opened this issue Apr 10, 2018 · 0 comments
Assignees
@chenba
Milestone
Stretch

Comments

@chenba
Copy link
Collaborator

chenba commented Apr 10, 2018

The NODE_ENV env var is not set in prod, which might not be desirable. The only thing that this is currently affecting is the Raven configuration.

The simplest and most direct way to do this is just set it in the _run-docker script, where a few other env vars are set.
@marniepw marniepw added this to the Sprint 11 (61-3) 👗 milestone Apr 11, 2018
@chenba chenba self-assigned this Apr 26, 2018
chenba added a commit to chenba/screenshots that referenced this issue Apr 26, 2018
@chenba
Set a default NODE_ENV of 'production' in Docker image. (mozilla-serv…
291eb4d 
…ices#4326)
@chenba chenba mentioned this issue Apr 26, 2018
Merged
@ghost ghost modified the milestones: Sprint 11 (61-3) 👗, Stretch Apr 30, 2018
jaredhirsch pushed a commit that referenced this issue Apr 30, 2018
@chenba @jaredhirsch
Set a default NODE_ENV of 'production' in Docker image. (#4326) (#4385)
62ec921
testeaxeax pushed a commit to testeaxeax/screenshots that referenced this issue Jun 7, 2018
@chenba
Set a default NODE_ENV of 'production' in Docker image. (mozilla-serv…
df3a568 
…ices#4326) (mozilla-services#4385)
testeaxeax pushed a commit to testeaxeax/screenshots that referenced this issue Jun 7, 2018
Revert "Set a default NODE_ENV of 'production' in Docker image. (mozi…
9eb64cd 
…lla-services#4326) (mozilla-services#4385)"

This reverts commit df3a568.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenba chenba

Labels
None yet
Projects
None yet
Milestone
Stretch
Development

No branches or pull requests
2 participants
@chenba @marniepw