This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Exclude shots from Watchdog based on Firefox version/channel #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenba
commented
Sep 5, 2018
| const firefoxMajorReleases = { | ||
| 63: new Date("2018-10-23"), | ||
| 64: new Date("2018-12-11"), | ||
| 65: new Date("2019-01-29"), |
There was a problem hiding this comment.
@clouserw with the patch as it is, it'll work until Firefox 66 is released. There's also a flag to control whether we check the channel/version at all.
There was a problem hiding this comment.
That sounds great. If we get past Firefox 66 without figuring out what we're doing here let's make sure the failure mode is to not submit images. Thanks!
chenba
force-pushed
the
4770-watchdog-channel
branch
from
6f1c3ac
to
d89aa80
Compare
jaredhirsch
approved these changes
Sep 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4770