This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Clean up shot.js #2330
Merged
Clean up shot.js #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jaredhirsch
requested review from
jaredhirsch
and removed request for
jaredhirsch
|
@fzzzy any chance you could review this one? I'm still a bit hesitant about reviewing wide-ranging changes to the page shot code |
|
@6a68 yep, sure |
fzzzy
reviewed
Mar 10, 2017
| Shot.get(req.backend, shotId).then((shot) => { | ||
| if (shot.deviceId !== req.deviceId) { | ||
| simpleResponse(res, "Not the owner", 403); | ||
| Shot.get(req.backend, shotId, req.deviceId).then((shot) => { |
There was a problem hiding this comment.
So since req.deviceId is getting passed in to get now, if the user doesn't own the shot, they just will get a 404 instead of 403 Not the owner, right?
|
Nice cleanup! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2156
Remove leftover references to body/head DOM attributes