Add an HTTP-level test that migration produces a 503. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfk
commented
Jan 24, 2020
| return orig_do_request(req, *args, **kwds) | ||
|
|
||
| orig_do_request = app.do_request | ||
| app.do_request = new_do_request |
There was a problem hiding this comment.
As far as I can tell this was just duplicated code from the make_test_app method, so I cleaned it up while I was in here.
rfk
force-pushed
the
migration-extra-test
branch
from
fc2c9c1
to
e76e932
Compare
jrconlin
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to test something about the behaviour of #136, so figured I may as well do it as an actual testcase. @jrconlin r?