Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for diffs between current lists and Disconnect's #324

Open
1 task
say-yawn opened this issue Aug 12, 2020 · 4 comments
Open
1 task

Check for diffs between current lists and Disconnect's #324

say-yawn opened this issue Aug 12, 2020 · 4 comments

Comments

@say-yawn
Copy link
Contributor

About this Issue

#322 pointed out that there may be discrepancy between Shavar lists and https://github.com/disconnectme/disconnect-tracking-protection lists. We want to check that there are no other unexpected discrepancy and that checks are happening to prevent that

Acceptance Criteria

  • Check the diff between Disconnect's and Shavar's lists
@kasnder
Copy link
Contributor

kasnder commented Aug 12, 2020

I've written a small script to compare differences: https://gist.github.com/kasnder/cf3548241ffc56f91a4e739bbfac3131

@kasnder
Copy link
Contributor

kasnder commented Aug 12, 2020

The script correctly identifies crashlytics.com as differently classified in your previous blacklist.

The script also finds that your blacklist misses out on avantmetrics.com.

@say-yawn
Copy link
Contributor Author

@kasnder thanks for creating the helpful script. Do you mind if we add the script to the scripts folder in this repo? If you can add that to the #337 PR I can use the script for additional CI check.

@kasnder
Copy link
Contributor

kasnder commented Aug 15, 2020

Did some cleaning up, and added this now to the #337 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants