fixes bug 1375431 - remove "build graph" from signature report (#3852)

* fixes bug 1375431 - remove "build graph" from signature report

* remove test-breakage

webapp-django/crashstats/settings/bundles.py

@@ -359,7 +359,6 @@
             'signature/js/signature_tab_comments.js',
             'signature/js/signature_tab_correlations.js',
             'signature/js/signature_tab_bugzilla.js',
-            'signature/js/signature_tab_graph.js',
             'signature/js/signature_panel.js',
         ),
         'output_filename': 'js/signature-report.min.js',

webapp-django/crashstats/signature/jinja2/signature/signature_report.html

@@ -23,13 +23,11 @@
     data-urls-bugzilla="{{ url('signature:signature_bugzilla') }}"
     data-urls-comments="{{ url('signature:signature_comments') }}"
     data-urls-correlations="{{ url('signature:signature_correlations') }}"
-    data-urls-graph="{{ url('signature:signature_report') }}graphdata/"
 
     data-channels="{{ channels | to_json }}"
     data-fields="{{ fields | to_json }}"
     data-columns="{{ columns | to_json }}"
     data-sort="{{ sort | join(',') }}"
-    data-default-channel="{{ channel }}"
 >
     <div class="page-heading">
         <h2>Signature report for <em>{{ signature }}</em></h2>
@@ -72,7 +70,6 @@ <h2>Signature report for <em>{{ signature }}</em></h2>
             <li><a href="#bugzilla" class="bugzilla" data-tab-name="bugzilla">Bugzilla</a></li>
             <li><a href="#comments" class="comments" data-tab-name="comments">Comments</a></li>
             <li><a href="#correlations" class="correlations" data-tab-name="correlations">Correlations</a></li>
-            <li><a href="#graph" class="graph" data-tab-name="graph">Build Graph</a></li>
         </ul>
     </nav>
 

webapp-django/crashstats/signature/static/signature/css/signature_report.less

@@ -150,14 +150,6 @@ section.summary-panel .panel {
     }
 }
 
-section.graph-panel {
-    .controls {
-        .channels-list {
-            width: 30%;
-        }
-    }
-}
-
 section.graphs-panel {
     .controls {
         .fields-list {

webapp-django/crashstats/signature/static/signature/js/signature_report.js

@@ -42,7 +42,6 @@ SignatureReport.init = function () {
         'bugzilla': SignatureReport.BugzillaTab,
         'comments': SignatureReport.CommentsTab,
         'correlations': SignatureReport.CorrelationsTab,
-        'graph': SignatureReport.GraphTab,
     };
 
     // Set the current tab, either from location.hash or defaultTab.

webapp-django/crashstats/signature/tests/test_views.py

@@ -554,80 +554,6 @@ def mocked_supersearch_get(**params):
         ok_('99' not in response.content)
         ok_('139' in response.content)
 
-    @mock.patch('requests.get')
-    def test_signature_graph_data(self, rget):
-        def mocked_get(**options):
-
-            # Check the mandatory parameters are present and correct
-            ok_('signature' in options)
-            eq_(options['signature'], DUMB_SIGNATURE)
-
-            ok_('product_name' in options)
-            eq_(options['product_name'], 'WaterWolf')
-
-            ok_('channel' in options)
-            eq_(options['channel'], 'nightly')
-
-            ok_('start_date' in options)
-            eq_(options['start_date'], '2014-12-25')
-
-            ok_('end_date' in options)
-            eq_(options['end_date'], '2015-01-01')
-
-            # Return empty object, since the view doesn't
-            # process the data
-            return {}
-
-        # rget.side_effect = mocked_get
-        models.AduBySignature.implementation().get.side_effect = mocked_get
-
-        url = reverse(
-            'signature:signature_graph_data',
-            args=('nightly',)
-        )
-
-        # Test that the params get passed through to the api correctly
-        self.client.get(url, {
-            'signature': [DUMB_SIGNATURE],
-            'product': ['WaterWolf'],
-            'date': ['>=2014-12-25', '<=2015-01-01'],
-        })
-
-        # Check the the earliest given start date becomes start_date
-        self.client.get(url, {
-            'signature': [DUMB_SIGNATURE],
-            'product': ['WaterWolf'],
-            'date': ['>=2014-12-25', '>=2014-12-28', '<=2015-01-01'],
-        })
-
-        # Check the the latest given end date becomes end_date
-        self.client.get(url, {
-            'signature': [DUMB_SIGNATURE],
-            'product': ['WaterWolf'],
-            'date': ['>=2014-12-25', '<=2014-12-29', '<=2015-01-01'],
-        })
-
-        # If date starts with >, check that start_date is 1 day more
-        self.client.get(url, {
-            'signature': [DUMB_SIGNATURE],
-            'product': ['WaterWolf'],
-            'date': ['>2014-12-24', '<=2015-01-01'],
-        })
-
-        # If date starts with <, check that end_date is 1 day less
-        self.client.get(url, {
-            'signature': [DUMB_SIGNATURE],
-            'product': ['WaterWolf'],
-            'date': ['>=2014-12-25', '<2015-01-02'],
-        })
-
-        # If no start date was given, check it is 7 days less than end_date
-        self.client.get(url, {
-            'signature': [DUMB_SIGNATURE],
-            'product': ['WaterWolf'],
-            'date': '<=2015-01-01'
-        })
-
     def test_signature_summary(self):
 
         def mocked_get_graphics_devices(**params):

webapp-django/crashstats/signature/urls.py

@@ -19,11 +19,6 @@
         views.signature_correlations,
         name='signature_correlations',
     ),
-    url(
-        r'^graphdata/(?P<channel>\w+)/$',
-        views.signature_graph_data,
-        name='signature_graph_data',
-    ),
     url(
         r'^aggregation/(?P<aggregation>\w+)/$',
         views.signature_aggregation,