Skip to content

Commit

Permalink
bug-1876623: Treat <.plt ELF section...> as prefix signature (#6519)
Browse files Browse the repository at this point in the history
Treat frames like `<.plt ELF section in libxul.so>` as prefix signatures.

For example, this bug is not a useful aggregation:
https://bugzilla.mozilla.org/show_bug.cgi?id=1870546

That includes the crash:
https://crash-stats.mozilla.org/report/index/82af7f36-4ed2-4826-bdd6-6397c0240118

whose stack begins:

```
<.plt ELF section in libxul.so>
js::wasm::Instance::callExport(JSContext*, unsigned int, JS::CallArgs, js::wasm::CoercionLevel)
```

That second frame would be a much more interesting thing to file the crash under.
  • Loading branch information
jimblandy committed Jan 26, 2024
1 parent 32ccc16 commit 7bc37bc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions socorro/signature/siglists/prefix_signature_re.txt
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ o_strcat_s
<.*>::operator()
pages_commit
PL_
<\.plt ELF section in .*>
port_
PORT_
_PR_
Expand Down

0 comments on commit 7bc37bc

Please sign in to comment.