fixes bug 1394909 - correct order of table deletions with partitions (#…

…3957)
mozilla-services · Sep 5, 2017 · c185523 · c185523
1 parent 2ba5e85
commit c185523
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/alembic/versions/07c6633fa1b6_delete_signature_summaries.py b/alembic/versions/07c6633fa1b6_delete_signature_summaries.py
@@ -26,7 +26,12 @@ def upgrade():
         table_name, = records
         all_table_names.append(table_name)
 
-    # Now delete all these massive tables
+    # Now delete all these massive tables.
+    # But make sure that we drop them in the "right" order.
+    # In particular we want to make sure we first drop
+    # 'signature_summary_os_20130603' *before* we drop 'signature_summary_os'
+    # since the former depends on the latter.
+    all_table_names.sort(reverse=True)
     for table_name in all_table_names:
         op.execute('DROP TABLE IF EXISTS {}'.format(table_name))