bug 832083 adding B2G to our scraper #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rhelmer r? |
| try: | ||
| day = date.strftime('%d') | ||
| dir_prefix = '%s-%s-%s' % (date.year, month, day) | ||
| # I have no idea what this first level of directories means :/ |
There was a problem hiding this comment.
Did you figure this out? :) is it the 1.0.0 part, isn't that B2G version #?
|
lgtm overall. I don't like how much special casing this needs but I understand why it is done. Hopefully this will become more standardized across products over time (or we can move scraping elsewhere and let socorro use a decent API) |
selenamarie
added a commit
that referenced
this pull request
Feb 13, 2013
bug 832083 adding B2G to our scraper
rhelmer
pushed a commit
to rhelmer/socorro
that referenced
this pull request
Sep 6, 2013
…i_fireplace_featured Add Collections to Fireplace featured API endpoint (bug 901710)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JSON parsing and ftp scraping descent into manifest directory for B2G.