fixes Bug 949539 (v71) - changed to configman 1.1.15 #1737
Conversation
|
why does this PR touch so many files? Configman has had a long standing bug that allowed laxity in command line arguments. Give it something totally wrong? Configman didn't care and would just ignore the bad argument. That but has been fix, bad command line arguments is an error. However, when nosetests is run with command line switches, nose's own switches get passed down to the underlying code being tested. so "-s --with-xunit" gets sent to Configman and Configman vomits with rage. The solution was simple, but tedious. Every time we instantiate a ConfigurationManager, we have to explicitly say that the |
| @@ -85,7 +85,8 @@ def _setup_config_manager(self, jobs_string, extra_value_source=None): | |||
| ], | |||
| values_source_list=value_source, | |||
| app_name='crontabber', | |||
| app_description=__doc__ | |||
| app_description=__doc__, | |||
| argv_source=[] | |||
There was a problem hiding this comment.
Same here, can you please add a trailing coma to make future diffs smaller?
|
r+ I won't be offended if you do not add those comas, I realize it would be a pain to do. |
fixes Bug 949539 (v71) - changed to configman 1.1.15
updated socorro to configman 1.1.15
for release 71 - do not merge earlier